Warn for typo'd folders #399 - #479
Conversation
… checks (which feels more appropriate)
|
This feels a bit overaggressive to me, adding warnings that you can't silence without (IMO) a clear upside (I can't think of a bug that this would have caught). For example, for Swedish IOI qualifiers we regularly use a directory I've also in the recent past used directories like |
|
Yeah I thought the idea was to catch levenshtein distance 1 or 2 typo errors, not warn on arbitrary directories. |
I think the upside is exactly the example given in the issue, catching stuff like calling a directory But, good points. I'll look at tweaking to allow for more clutter. |
4 participants
Adds a check looking at directories in the root of the problem package, warning for unknown directories (and suggesting the closest known match, if anything is close). This check replaces 3 bespoke checks for the same thing in various places.
Drops the check for unknown directories in submissions/. I covered this warning when extracting submission checks (we now look in all directories for submissions, and will warn about unknown submissions), so it's now basically a duplicate.
Renames the variable/function parameter
formattoformat_versionto avoid shadowing the built-in.Fixes #399